This repository has been archived by the owner on Oct 28, 2024. It is now read-only.
forked from mastodon/mastodon-android
-
Notifications
You must be signed in to change notification settings - Fork 32
Iceshrimp improvements #1000
Open
Jacocococo
wants to merge
23
commits into
sk22:main
Choose a base branch
from
Jacocococo:iceshrimp-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Iceshrimp improvements #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This information is very useful and it's loaded very quickly anyways
- Hide emoji reactions - Correctly set editedAt
The constructor of AccountSessionManager may need this object which could lead to a situation where it was being used before it had been created. Making it static and moving it to MastodonAPIRequest, the only place it was being used anyways, seems to fix the issue.
This is specifically for tapping existing reactions on a post if the user has already reached the instance max
We can be sure it doesn't support anything other than MFM
It's disabled anyways for new users, and allowing all lowers the chance of crashes from a previously selected option being missing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of improvements to make the experience better on Iceshrimp. These include:
(I am aware that this project isn't currently active and don't expect much to be done with this PR in this repo. I started working on it a while ago (as seen in the commit dates) and decided I might as well finish it)