Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use g:colors_name instead of colors_name #22

Open
ressu opened this issue Oct 20, 2015 · 5 comments
Open

use g:colors_name instead of colors_name #22

ressu opened this issue Oct 20, 2015 · 5 comments

Comments

@ressu
Copy link
Contributor

ressu commented Oct 20, 2015

I was debugging an issue with vim startup colors and noticed that badwolf doesn't set the colors_name properly. Which essentially means that :colorscheme will always return default.

the proper variable to use (according to vim documentation) is g:colors_name and not colors_name as it is currently.

@captm0rgan
Copy link

I'm having an issue where vim won't apply badwolf unless I run "colorscheme badwolf" directly instead of having it in my .vimrc. Is this what's causing it?

@ressu
Copy link
Contributor Author

ressu commented Nov 15, 2015

It's the most likely culprit. If your vim startup (most likely some script) tries to reload the theme, it will load the default theme instead. For me, this shows up when I try to invoke :gui from a terminal vim session.

Let me whip up a pull request for this..

@captm0rgan
Copy link

Yeah. That fixed it. Thanks.

Edit: It appears that it didn't fix it. I don't know why it appeared to be working.

@captm0rgan
Copy link

So it appears to be dependent on the version of vim. Some of my machines work with the fix, and some don't. It's weird. All well.

@ressu
Copy link
Contributor Author

ressu commented Nov 18, 2015

There are a few caveats in themes. But I don't think they apply here.. If you aren't using my fork directly, the cause could be that the issue title talks about color_name when it should be colors_name. Other than that, the documentation doesn't mention any limitations on vim versions, so I would assume that there hasn't been any recent changes.

solomonxie added a commit to solomonxie/badwolf that referenced this issue Dec 30, 2021
This causes vim to properly reload the correct theme when needed.

Fixes issue sjl#22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants