From f8bdce630940d38f6193e4fce8b0620a9a9fe023 Mon Sep 17 00:00:00 2001 From: Julia Dark <24235303+jp-dark@users.noreply.github.com> Date: Fri, 22 Mar 2024 11:20:25 -0400 Subject: [PATCH] Remove optional keyword args from IndexLike.get_indexer (#190) We only use the `target` positional argument from the pandas `Index.get_indexer` method. Remove optional keyword arguments to allow greater flexibility when implementing a `IndexLike` class. --- python-spec/src/somacore/query/types.py | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/python-spec/src/somacore/query/types.py b/python-spec/src/somacore/query/types.py index 2b63b22a..ca9d8de6 100644 --- a/python-spec/src/somacore/query/types.py +++ b/python-spec/src/somacore/query/types.py @@ -16,13 +16,7 @@ class IndexLike(Protocol): not as a full specification of the types and behavior of ``get_indexer``. """ - def get_indexer( - self, - target: npt.NDArray[np.int64], - method: object = ..., - limit: object = ..., - tolerance: object = ..., - ) -> Any: + def get_indexer(self, target: npt.NDArray[np.int64]) -> Any: """Something compatible with Pandas' Index.get_indexer method."""