Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning for Client/Server #29

Closed
2 tasks
fkettelhoit opened this issue Nov 30, 2022 · 1 comment
Closed
2 tasks

Versioning for Client/Server #29

fkettelhoit opened this issue Nov 30, 2022 · 1 comment

Comments

@fkettelhoit
Copy link
Contributor

Now that the repository is public, we should start thinking about how we want to handle a version mismatch between the client and server. Since the playground (or rather the echo server) is auto-deployed whenever something changes on main, everyone using a previously installed tandem_http_client will simply get a very confusing error message whenever a change results in incompatibility:

tandem_http_client --function main --input 3u8 --metadata 7u8 add.garble.rs
Error: MaxRetriesExceeded([ServerError("{\"error\":\"BincodeError\"}"), ServerError("{\"error\":\"BincodeError\"}"), ServerError("{\"error\":\"BincodeError\"}"), ServerError("{\"error\":\"BincodeError\"}"), ServerError("{\"error\":\"BincodeError\"}"), ServerError("{\"error\":\"BincodeError\"}"), ServerError("{\"error\":\"BincodeError\"}"), ServerError("{\"error\":\"BincodeError\"}"), ServerError("{\"error\":\"BincodeError\"}"), ServerError("{\"error\":\"BincodeError\"}")])

I would propose 2 changes:

  • only deploy new versions to fly.io when a new tag is pushed (not on every commit)
  • check the client version against the server version, print a more helpful error message in case there's a mismatch
@fkettelhoit
Copy link
Contributor Author

Sorry, closing this here, as it was supposed to be an issue in the Tandem repo instead: sine-fdn/tandem#17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant