Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give images the same order number regardleses of viewer and regardless of if it has been deleted #17

Closed
simonv3 opened this issue Feb 14, 2016 · 1 comment

Comments

@simonv3
Copy link
Owner

simonv3 commented Feb 14, 2016

Asheesh noted in-app that the annotations renumber themselves when you delete one. FWIW I think it would be better if an annotation's number never changed, since I might, say, send someone an email like "Hey take a look at #18, blah blah blah". (It might also make sense for these number to be unique across all the annotations in the grain, not just per-image.)

@simonv3
Copy link
Owner Author

simonv3 commented Feb 14, 2016

I talked with Asheesh about the re-numbering. I concluded the same thing you did - it'd be great to reference an annotation and to be sure it remained the same. However, what with the ability to delete annotations, this means keeping track of what the most recent annotation was on an image (to avoid the "create two 7s" problem that this fixed). I'm going to have to think about how to best implement that. I'm not sure whether storing on an annotation will be enough - there might be a race condition if someone quickly adds or deletes two images while waiting for the DB to update, and then you'd still have the "two 7s" problem. Or it might require re-structuring the data in the app (annotations aren't embedded within images at the moment, for no real good reason).

@simonv3 simonv3 closed this as completed Feb 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant