Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge shipping, tax, and discounts submodules into core #127

Closed
jedateach opened this issue Dec 18, 2012 · 5 comments
Closed

Merge shipping, tax, and discounts submodules into core #127

jedateach opened this issue Dec 18, 2012 · 5 comments
Assignees

Comments

@jedateach
Copy link
Contributor

Development on the discount and shipping modules has progressed well. They are now getting more co-dependent. I thin it is time to commit to these features and combine them into the core shop module.

Currently the issues appear to be arising with the modifiers system. I'm thinking it might be time to do away with order modifiers: #128

@ghost ghost assigned jedateach Dec 18, 2012
@wildflower
Copy link
Contributor

I haven't read any of the code so this may be irrelevant but, does the shipping modules have different types of Track and trace links for different couriers? NZ Post, FedEx, DHL etc it think they all do it slightly differently

@jedateach
Copy link
Contributor Author

It doesn't currently, but I've tried to abstract with that in mind.

The ShippingMethod base class has a calculateRate function to be overridden, where you can do API fetching etc.

Here's some code to demonstrate:

class NZPostShippingMethod extends ShippingMethod{

    function calculateRate(ShippingPackage $package, Address $address){
        //fetch rate via API ...
    }

}

@wildflower
Copy link
Contributor

Track and Trace would be more at the end of the Order process when the store owner puts the item in a box and 'Ships' the order.
I guess it could effect email templates, or the back end screens, it could be a standard field but each courier would have their own URI format

@jedateach
Copy link
Contributor Author

Oh, sorry I didn't read your comment properly. No track & trace built in yet.

Might be worth borrowing ideas from https://github.com/Shopify/active_shipping

@wilr
Copy link
Contributor

wilr commented Feb 19, 2016

Archiving as separate modules was decided the way to go.

@wilr wilr closed this as completed Feb 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants