Updated Ubuntu and nginx versions. #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashilias
commented
Sep 23, 2022
bashilias
commented
- Moved to Ubuntu 22.04 and Nginx 1.22.
- Added Docker install script to README.
|
Any reason not to just base these Dockerfiles of https://hub.docker.com/_/nginx/ instead? |
Closed
martinezpl
approved these changes
Oct 12, 2022
|
|
||
| RUN apt-get update && apt-get -y upgrade && \ | ||
| apt-get install -y wget libpcre3-dev build-essential libssl-dev zlib1g-dev && \ | ||
| rm -rf /var/lib/apt/lists/* | ||
|
|
||
| WORKDIR /opt | ||
|
|
||
| RUN wget https://nginx.org/download/nginx-1.18.0.tar.gz && \ | ||
| RUN wget https://nginx.org/download/nginx-1.22.0.tar.gz && \ |
There was a problem hiding this comment.
Suggested change
| RUN wget https://nginx.org/download/nginx-1.22.0.tar.gz && \ | |
| RUN wget https://nginx.org/download/nginx-1.23.1.tar.gz && \ |
|
|
||
| RUN apt-get update && apt-get -y upgrade && \ | ||
| apt-get install -y wget libpcre3-dev build-essential libssl-dev zlib1g-dev && \ | ||
| rm -rf /var/lib/apt/lists/* | ||
|
|
||
| WORKDIR /opt | ||
|
|
||
| RUN wget https://nginx.org/download/nginx-1.18.0.tar.gz && \ | ||
| RUN wget https://nginx.org/download/nginx-1.22.0.tar.gz && \ |
There was a problem hiding this comment.
Suggested change
| RUN wget https://nginx.org/download/nginx-1.22.0.tar.gz && \ | |
| RUN wget https://nginx.org/download/nginx-1.23.1.tar.gz && \ |
|
To be honest I just think it's better to use the upstream images. Bumping manually is tiring, and it's not like Signal merge pull requests for this repo often. Even if this does get merged, it will quickly become outdated again. |
|
Not relevant anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.