Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I think use AND rather than OR is better, now the if always to true #27

Open
murenma05 opened this issue Jul 10, 2024 · 0 comments
Open

I think use AND rather than OR is better, now the if always to true #27

murenma05 opened this issue Jul 10, 2024 · 0 comments

Comments

@murenma05
Copy link

Hi Sichkar, thanks for this repo, very helpful to RL beginners like me. In agent-brain's code, i think there should use 'and' of this line:

 if next_state != 'goal' or next_state != 'obstacle':

Otherwise this judgement will always be true.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@murenma05