Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blazegraph: include/with removal #9

Open
JervenBolleman opened this issue Sep 20, 2024 · 2 comments
Open

Blazegraph: include/with removal #9

JervenBolleman opened this issue Sep 20, 2024 · 2 comments
Labels
query-fixing Things arround fixing queryies to become more standard.

Comments

@JervenBolleman
Copy link
Collaborator

We remove some but not all. Code depends on a REGEX but we should instead count opening and closing brackets.

@JervenBolleman
Copy link
Collaborator Author

SELECT DISTINCT ?person ?personLabel ?dob ?occupation ?occupationLabel ?image with {
SELECT DISTINCT ?person
WHERE
{
 ?person wdt:P569 ?dob .
 FILTER (?dob = \"1999-05-19\"^^xsd:dateTime)
  } } as %i
where
{
  include %i
 ?person wdt:P31 wd:Q5 .
 ?person wdt:P106 ?occupation .
 ?person wdt:P18 ?image .       # Query reaches timeout, thought if I add OPTIONAL it works even s,o that this way it has to show more results. How is this possible, and how to make it work without OPTIONAL?
 SERVICE wikibase:label { bd:serviceParam wikibase:language \"[AUTO_LANGUAGE],en\". }
}

Does not match the replacement regex and is therefore not fixed. At the time of making this issue 737 with/include queries are not yet auto fixed.

@JervenBolleman
Copy link
Collaborator Author

mvn package;
java -jar target/sparql-examples-utils-2.0.1-uber.jar test -i /home/jbollema/git/wikibase-sparql-examples/examples/ -p wikidata > test.log;
sed '/testAllWithBigD/q' test.log | grep '✘' |grep with |wc -l 

is the hacky code to quickly see the failing cases.

@JervenBolleman JervenBolleman added the query-fixing Things arround fixing queryies to become more standard. label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
query-fixing Things arround fixing queryies to become more standard.
Projects
None yet
Development

No branches or pull requests

1 participant