Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation sometimes uses attributes, sometimes annotations - should probably only use attributes now #1224

Closed
AndreasA opened this issue Dec 6, 2023 · 3 comments
Assignees
Labels
Core @ct-core DX Team #dev-docs

Comments

@AndreasA
Copy link

AndreasA commented Dec 6, 2023

I noticed upon browsing the documentation that although it mostly now uses attributes, some still mention annotations like https://developer.shopware.com/docs/guides/plugins/plugins/content/seo/add-custom-seo-url.html#example-controller

@Isengo1989
Copy link
Collaborator

@AndreasA thank you for the hint 👍

@shyim I saw you applied the changes from annotations to attributes with rector rules. Is this already rolled out for the whole project? If so we would apply it to >= 6.5

@Isengo1989 Isengo1989 added Core @ct-core DX Team #dev-docs labels Dec 6, 2023
@shyim
Copy link
Member

shyim commented Dec 6, 2023

we don't have any annotations anymore in 6.6. we don't support annotations even anymore

@Isengo1989 Isengo1989 self-assigned this Dec 18, 2023
@Isengo1989
Copy link
Collaborator

Closed with #1238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core @ct-core DX Team #dev-docs
Projects
None yet
Development

No branches or pull requests

3 participants