You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
if direction == "minimize":
self._operator = operator.lt
self.tolerance = -tolerance
self._score = inf
elif direction == "minimize":
self._operator = operator.gt
self.tolerance = tolerance
self._score = -inf
I believe that the second if statement should be "maximize" instead.
To be fair, the code itself does not seem to be affected, since the only place where EarlyStoppingCallback is used is in a single statement within the same file,
In https://github.com/shlienlab/raccoon/blob/3a3a9e3f20819f9bfd8b739425f5812de66339f6/raccoon/optim/tpe.py#L68C7-L68C28, there is a class
EarlyStoppingCallback
. In the comments, it is mentioned that the direction can be""minimize" or "minimize"
, which clearly omits the"maximize"
case.In the code itself, lines 86-93, we have
I believe that the second if statement should be
"maximize"
instead.To be fair, the code itself does not seem to be affected, since the only place where
EarlyStoppingCallback
is used is in a single statement within the same file,so the impact isn't really huge unless other users are also create
EarlyStoppingCallback
instances.The text was updated successfully, but these errors were encountered: