Fix CMYK from-conversion and add it as possible color function #200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled across this project yesterday, and it's a really cool tool :)
I'm trying to create a colorscheme for my text editor base on some design book I own, in which all colors are specified using the CMYK format.
Using pastel to convert from CMYK to hex, so my editor would understand it, seemed like a no-brainer, but even though the
Self::from(CMYK)
function exists, it is never used anywhere in the project.Also, I've noticed the calculation were wrong in that function, so I fixed those and add the corresponding
parse_cmyk
function, so it can be used as a color value in commands.This is my first time "writing" rust code, please feel free to report any mistake I've made :)
I would understand if this is rejected because it's too niche of a usage.