Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Dialog abstraction throwsDialogContent requires a DialogTitle since last update #5924

Open
2 tasks done
Alicehhhmm opened this issue Nov 24, 2024 · 0 comments
Open
2 tasks done
Labels
bug Something isn't working

Comments

@Alicehhhmm
Copy link

Describe the bug

Current Behavior

Error message about using @radix-ui/react-dialog library for shadcn components

Affected component/components

command

How to reproduce

ERROR

Dialog abstraction throwsDialogContent requires a DialogTitle since last update

image

Expected behavior

There is no error when using shadcn components associated with @radix-ui/react-dialog for example: command

My local solution

components/ui/dialog

import * as DialogPrimitive from '@radix-ui/react-dialog'

const DialogContent = React.forwardRef<
  ....
>(({ className, children, ...props }, ref) => (
    <DialogPortal>
        ....
        <DialogPrimitive.Content
            ....
+            aria-describedby={undefined}
        >
+             <DialogPrimitive.Title className='hidden'>visually hidden</DialogPrimitive.Title>
            {children}
             ....
        </DialogPrimitive.Content>
    </DialogPortal>
))

correlation lssues

#4302
#5474
#5698
#5746

radix-ui lssues

#2986

Codesandbox/StackBlitz link

https://ui.shadcn.com/docs/components/command

Logs

No response

System Info

[✔] Environment
    - OS: Windows 10.0.19045 x86_64 (X64)
    - node: 20.17.0
    - pnpm: 9.10.0
    - yarn: 1.22.22
    - npm: 10.7.0

Before submitting

  • I've made research efforts and searched the documentation
  • I've searched for existing issues
@Alicehhhmm Alicehhhmm added the bug Something isn't working label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant