Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Similarity #485

Merged
merged 30 commits into from
Feb 23, 2023
Merged

Similarity #485

merged 30 commits into from
Feb 23, 2023

Conversation

alirezazolanvari
Copy link
Collaborator

Reference Issues/PRs

#349 #350

What does this implement/fix? Explain your changes.

23 new distance metrics are added.

Any other comments?

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2023

Codecov Report

Merging #485 (6f4007e) into dev (96612e4) will increase coverage by 0.05%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev     #485      +/-   ##
==========================================
+ Coverage   99.28%   99.33%   +0.05%     
==========================================
  Files          13       13              
  Lines        2915     3105     +190     
  Branches      448      447       -1     
==========================================
+ Hits         2894     3084     +190     
  Misses          8        8              
  Partials       13       13              
Impacted Files Coverage Δ
pycm/pycm_output.py 96.94% <ø> (ø)
pycm/pycm_param.py 100.00% <ø> (ø)
pycm/pycm_compare.py 100.00% <100.00%> (ø)
pycm/pycm_distance.py 100.00% <100.00%> (ø)
pycm/pycm_overall_func.py 100.00% <100.00%> (ø)
pycm/pycm_util.py 99.69% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@alirezazolanvari alirezazolanvari marked this pull request as draft February 13, 2023 12:36
@alirezazolanvari
Copy link
Collaborator Author

@sepandhaghighi You can start working on the document🙏

@sepandhaghighi sepandhaghighi marked this pull request as ready for review February 20, 2023 21:48
Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@@ -519,5 +519,5 @@ def online_help(param=None, alt_link=False):
print('Example : online_help("J") or online_help(2)\n')
for index, item in enumerate(params_link_keys):
print(str(index + 1) + "-" + item)
except Exception: # pragma: no cover
except Exception: # pragma: no cover
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space was added here.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at b7a63c3

Comment on lines 730 to 733
def sort_by(x): return [(x, False, False) if not re.findall(r'\d+', x)
else (x[:re.search(r'\d+', x).start()],
int(re.findall(r'\d+', x)[0]),
x[re.search(r'\d+', x).end():])]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

umm, not sure about this.
Maybe adding it as another function (parallel to sort_char_num) would be a better choice - rather than in the sort_char_num.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's autopep8 script output.
But you are right, I will solve it ASAP 🚀

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 625de03

@sadrasabouri sadrasabouri merged commit b1bcd64 into dev Feb 23, 2023
@sadrasabouri sadrasabouri deleted the similarity branch February 23, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request nlnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants