-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Similarity #485
Similarity #485
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## dev #485 +/- ##
==========================================
+ Coverage 99.28% 99.33% +0.05%
==========================================
Files 13 13
Lines 2915 3105 +190
Branches 448 447 -1
==========================================
+ Hits 2894 3084 +190
Misses 8 8
Partials 13 13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@sepandhaghighi You can start working on the document🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@@ -519,5 +519,5 @@ def online_help(param=None, alt_link=False): | |||
print('Example : online_help("J") or online_help(2)\n') | |||
for index, item in enumerate(params_link_keys): | |||
print(str(index + 1) + "-" + item) | |||
except Exception: # pragma: no cover | |||
except Exception: # pragma: no cover |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra space was added here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a look at b7a63c3
pycm/pycm_util.py
Outdated
def sort_by(x): return [(x, False, False) if not re.findall(r'\d+', x) | ||
else (x[:re.search(r'\d+', x).start()], | ||
int(re.findall(r'\d+', x)[0]), | ||
x[re.search(r'\d+', x).end():])] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
umm, not sure about this.
Maybe adding it as another function (parallel to sort_char_num
) would be a better choice - rather than in the sort_char_num
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's autopep8 script output.
But you are right, I will solve it ASAP 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 625de03
Reference Issues/PRs
#349 #350
What does this implement/fix? Explain your changes.
23 new distance metrics are added.
Any other comments?