Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Braun-Blanquet similarity #444

Merged
merged 11 commits into from
Aug 10, 2022
Merged

Braun-Blanquet similarity #444

merged 11 commits into from
Aug 10, 2022

Conversation

sepandhaghighi
Copy link
Owner

Reference Issues/PRs

#349

What does this implement/fix? Explain your changes.

  • Braun-Blanquet similarity added

Any other comments?

@sepandhaghighi sepandhaghighi added this to the PYCM 3.6 milestone Aug 10, 2022
@sepandhaghighi sepandhaghighi self-assigned this Aug 10, 2022
"<blockquote id=\"ref81\">81- S. S. Choi, S. H. Cha, and C. C. Tappert, \"A survey of binary similarity and distance measures,\" Journal of systemics, cybernetics and informatics, vol. 8, no. 1, pp. 43-48, 2010.</blockquote>\n"
"<blockquote id=\"ref81\">81- S. S. Choi, S. H. Cha, and C. C. Tappert, \"A survey of binary similarity and distance measures,\" Journal of systemics, cybernetics and informatics, vol. 8, no. 1, pp. 43-48, 2010.</blockquote>\n",
"\n",
"<blockquote id=\"ref82\">82- Josias Braun-Blanquet. Plant Sociology: The Study of Plant Communities. McGraw-Hill Book Company, New York, 1932.</blockquote>\n",
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alirezazolanvari Would you please check the format of the references? (82, 83)
Then I will update README.md

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sepandhaghighi the IEEE style bibliography of them are as follows. I couldn't find any other version of 83 for referencing.

"<blockquote id="ref82">82- J. Braun-Blanquet, "Plant sociology. The study of plant communities," Plant sociology. The study of plant communities. First ed., 1932.\n",
"\n",
"<blockquote id="ref83">83- C. C. Little, "Abydos Documentation," 2018.\n"

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alirezazolanvari
Take a look at this link
Zenodo gives you the option of changing the citation format.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a look but the provided citation in the IEEE style does not look correct. I suggest to use the google scholar format. I found the citation for its 2020 version.

"<blockquote id="ref83">83- C. C. Little, "Abydos Documentation," 2020.\n"

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2022

Codecov Report

Merging #444 (36a4460) into dev (db48191) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #444      +/-   ##
==========================================
+ Coverage   99.26%   99.27%   +0.01%     
==========================================
  Files          11       11              
  Lines        2426     2434       +8     
  Branches      396      396              
==========================================
+ Hits         2408     2416       +8     
  Misses          6        6              
  Partials       12       12              
Impacted Files Coverage Δ
pycm/pycm_class_func.py 100.00% <100.00%> (ø)
pycm/pycm_handler.py 100.00% <100.00%> (ø)
pycm/pycm_param.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sepandhaghighi
Copy link
Owner Author

@alirezazolanvari @sadrasabouri Please review this PR 🚀

Copy link
Collaborator

@alirezazolanvari alirezazolanvari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤜🤛

@sadrasabouri sadrasabouri merged commit 3427a21 into dev Aug 10, 2022
@sadrasabouri sadrasabouri deleted the braun_blanquet branch August 10, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants