Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modern templates #265

Merged
merged 8 commits into from
Feb 9, 2024
Merged

Modern templates #265

merged 8 commits into from
Feb 9, 2024

Conversation

sadrasabouri
Copy link
Collaborator

What does this implement/fix? Explain your changes.

Added

  • decoration_request.yml template
  • font_request.yml template
  • one_line_request.yml template
  • feature_request.yml template
  • config.yml for issue template

Changed

  • Bug report template modified

@sadrasabouri sadrasabouri added this to the art 6.2 milestone Jan 13, 2024
@sadrasabouri sadrasabouri self-assigned this Jan 13, 2024
Copy link

codecov bot commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (38dbf97) 99.84% compared to head (8c377e2) 99.84%.

❗ Current head 8c377e2 differs from pull request most recent head 7dcf2a6. Consider uploading reports for the commit 7dcf2a6 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #265   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files           7        7           
  Lines        1181     1181           
  Branches       81       81           
=======================================
  Hits         1179     1179           
  Misses          1        1           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sadrasabouri sadrasabouri marked this pull request as ready for review January 13, 2024 03:06
Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sadrasabouri Thanks for your efforts 🔥
Please take a look at my comments 💯

attributes:
label: Additional context
placeholder: >
If you have any additional context or information about the 1-line art (like the link to the source of it), please write it down here.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About the decoration

contact_links:
- name: Discord
url: https://discord.com/invite/FAAyq3QJqP
about: Ask questions and discuss with other art community members
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Art

Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sadrasabouri Please take a look at my comments 🔥

placeholder: >
ex: ▌│█║▌║▌║
validations:
required: false
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this item should be true

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 7dcf2a6.

placeholder: >
ex: (っ◕‿◕)っ
validations:
required: false
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this item should be true

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 7dcf2a6.

Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sepandhaghighi sepandhaghighi merged commit efbeafa into dev Feb 9, 2024
51 checks passed
@sepandhaghighi sepandhaghighi deleted the modern-templates branch February 9, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants