Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Line function #272

Open
sepandhaghighi opened this issue Jun 1, 2024 · 5 comments · Fixed by #289
Open

[Feature]: Line function #272

sepandhaghighi opened this issue Jun 1, 2024 · 5 comments · Fixed by #289
Assignees
Milestone

Comments

@sepandhaghighi
Copy link
Owner

sepandhaghighi commented Jun 1, 2024

Describe the feature you want to add

Adding line functions to art

from art import line, lprint
lprint(length=10, height=1, char="#")
##########
lprint(length=15, height=2, char="*")
***************
***************
line(length=10, height=1, char="#")
"##########"
line(length=15, height=2, char="*")
"***************\n***************"

Describe your proposed solution

No response

Describe alternatives you've considered, if relevant

No response

Additional context

Default values:

  1. length: 15
  2. height: 1
  3. char: #
@sepandhaghighi sepandhaghighi added this to the art 6.3 milestone Jul 8, 2024
@sepandhaghighi
Copy link
Owner Author

@AHReccese

Are you interested in taking care of this issue?

@AHReccese
Copy link

Yes, sure. I would be honored.
@sepandhaghighi

@sepandhaghighi
Copy link
Owner Author

@AHReccese
Feel free to begin this task.

@AHReccese
Copy link

@sepandhaghighi
Hi Sepand, I'm developing this feature, just in order to make sure I'm on the same page with you on the requested feature, I have some questions:

  1. The functino signature for lprint is int, int, char and I should print a grid of this char with associated length and height, is there any other options? selecting font for example like tprint?
  2. and the lprint function, basically prints the line function output right? I mean line returns str but lprint doesn't return anything, instead it prints to console.

@sepandhaghighi
Copy link
Owner Author

@sepandhaghighi Hi Sepand, I'm developing this feature, just in order to make sure I'm on the same page with you on the requested feature, I have some questions:

  1. The functino signature for lprint is int, int, char and I should print a grid of this char with associated length and height, is there any other options? selecting font for example like tprint?
  2. and the lprint function, basically prints the line function output right? I mean line returns str but lprint doesn't return anything, instead it prints to console.

@AHReccese Hi

  1. No. lprint and line should only accept char, height, and length parameters

  2. Yes exactly!

This was referenced Nov 18, 2024
@sepandhaghighi sepandhaghighi linked a pull request Nov 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants