Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print font name in random-na mode #205

Closed
sepandhaghighi opened this issue Jun 25, 2022 · 3 comments · Fixed by #261
Closed

Print font name in random-na mode #205

sepandhaghighi opened this issue Jun 25, 2022 · 3 comments · Fixed by #261
Assignees
Labels
Milestone

Comments

@sepandhaghighi
Copy link
Owner

Description

Some fonts are not printable in all environments.
In random-na mode, we should print the font name.

Steps/Code to Reproduce

>>> from art import *
>>> tprint("test","random-na")

Expected Behavior

[Warning] 'font-x' is not printable in this environment.

Actual Behavior

[Warning] 'random-na' is not printable in this environment.

Operating System

Windows 10

Python Version

Python 3.8

ART Version (Use : art.__version__)

ART 5.6

@sepandhaghighi sepandhaghighi added this to the art 5.8 milestone Jun 25, 2022
@sepandhaghighi sepandhaghighi removed this from the art 5.8 milestone Nov 20, 2022
@sepandhaghighi sepandhaghighi added this to the art 6.1 milestone Jun 14, 2023
@sepandhaghighi
Copy link
Owner Author

@sadrasabouri Do you have any interest to handle this issue?

@sadrasabouri
Copy link
Collaborator

@sepandhaghighi sure.

@sepandhaghighi
Copy link
Owner Author

I think the best way is to convert indirect_font function to a decorator like @font_handler and call it wherever needed.

@sepandhaghighi sepandhaghighi linked a pull request Sep 16, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants