Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics name ('tcp') is truncated when --scheme is used #77

Open
deepakdeore2004 opened this issue Mar 30, 2018 · 1 comment
Open

metrics name ('tcp') is truncated when --scheme is used #77

deepakdeore2004 opened this issue Mar 30, 2018 · 1 comment

Comments

@deepakdeore2004
Copy link

without --scheme usage:

[ec2-user@ip-10-127-251-45 ~]$ /opt/sensu/embedded/bin/metrics-netstat-tcp.rb -d
ip-10-127-251-45.us-west-2.compute.internal.tcp.UNKNOWN 0 1522370627
ip-10-127-251-45.us-west-2.compute.internal.tcp.ESTABLISHED 2 1522370627
ip-10-127-251-45.us-west-2.compute.internal.tcp.SYN_SENT 0 1522370627
ip-10-127-251-45.us-west-2.compute.internal.tcp.SYN_RECV 0 1522370627
ip-10-127-251-45.us-west-2.compute.internal.tcp.FIN_WAIT1 0 1522370627
ip-10-127-251-45.us-west-2.compute.internal.tcp.FIN_WAIT2 0 1522370627
ip-10-127-251-45.us-west-2.compute.internal.tcp.TIME_WAIT 0 1522370627
ip-10-127-251-45.us-west-2.compute.internal.tcp.CLOSE 0 1522370627
ip-10-127-251-45.us-west-2.compute.internal.tcp.CLOSE_WAIT 0 1522370627
ip-10-127-251-45.us-west-2.compute.internal.tcp.LAST_ACK 0 1522370627
ip-10-127-251-45.us-west-2.compute.internal.tcp.LISTEN 2 1522370627
ip-10-127-251-45.us-west-2.compute.internal.tcp.CLOSING 0 1522370627

tcp is truncated when --scheme is used:
[ec2-user@ip-10-127-251-45 ~]$ /opt/sensu/embedded/bin/metrics-netstat-tcp.rb -d --scheme web-server
web-server.UNKNOWN 0 1522370637
web-server.ESTABLISHED 2 1522370637
web-server.SYN_SENT 0 1522370637
web-server.SYN_RECV 0 1522370637
web-server.FIN_WAIT1 0 1522370637
web-server.FIN_WAIT2 0 1522370637
web-server.TIME_WAIT 0 1522370637
web-server.CLOSE 0 1522370637
web-server.CLOSE_WAIT 0 1522370637
web-server.LAST_ACK 0 1522370637
web-server.LISTEN 2 1522370637
web-server.CLOSING 0 1522370637

I added '.tcp.' int scheme option to tackle this problem, so not a big issue but thought to notify.

@Evesy
Copy link
Contributor

Evesy commented Apr 16, 2018

Hey,

I believe this is intended behaviour in line with all other metrics plugins; allowing users to completely redefine the metrics path.

Are there examples of other plugins where this behaviour is different that you've come across?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants