Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of nodemailer-sendgrid-transport #707

Merged
merged 0 commits into from
Dec 21, 2018

Conversation

Berkmann18
Copy link
Contributor

@Berkmann18 Berkmann18 commented Jul 27, 2018

Fixes

Closes nodemailer-sendgrid-transport#67.

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

Short description of what this PR does:

  • Integrates the then nodemailer-sendgrid-transport package as a sub-package among others (while having it match and follow the structure/convention used by other sub-packages).
  • Help with PRs such as NST#67, NST#64 and issues such as NST#65 and NST#25.

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

Note: (as discussed in the PR mentioned above): the npm test fails due to the usage of the former sendgrid package in this codebase with some API changes and some sub-packages not available yet on NPM (causing all require('@sendgrid/xxx') to fail).

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jul 27, 2018
@thinkingserious
Copy link
Contributor

This is awesome, thanks! I've added this to our backlog for review.

@thinkingserious
Copy link
Contributor

Hello @Berkmann18,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@Berkmann18
Copy link
Contributor Author

@thinkingserious You're welcome.
I've had a look at it and I'm wondering what the "Attention" field is for, is that to do with what I did, or something to avoid putting/using on the t-shirt?

@gian1200
Copy link

Was this PR rolled back? Can't find a not vulnerable version of nodemailer-sendgrid-transport that works with SendGrid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: hard fix is hard in difficulty status: code review request requesting a community code review or review from Twilio type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants