Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate attachments by filename are removed #17

Open
deepwell opened this issue Sep 3, 2015 · 1 comment
Open

Duplicate attachments by filename are removed #17

deepwell opened this issue Sep 3, 2015 · 1 comment

Comments

@deepwell
Copy link

deepwell commented Sep 3, 2015

Adding more than 1 attachment with the same filename(s) are removed when sending with nodemailer-sendgrid-tranport. This bug does not effect other transports.

Eg: attachments

[
  { filename: 'presentation.xlsx',
    path: '/home/users/files/2f7402e1-4345-45bb-969a-e67b68c17e90.xlsx' },
  { filename: 'presentation.xlsx',
    path: '/home/users/files/0sdfhi43t-sfefio-sdfsdf-3433-33-324234lkd.xlsx' } 
]

Expectation:
Attachments should not be removed.

@deepwell
Copy link
Author

deepwell commented Sep 3, 2015

It looks like the fix is here: https://github.com/sendgrid/sendgrid-nodejs/pull/180/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants