Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-3663] fix: Correct Copy: Satribute not Sattribute #792

Merged

Conversation

terencehh
Copy link
Contributor

@terencehh terencehh commented Feb 6, 2024

🔘 PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

📜 Background

rename Sattributes to Satributes

Issue Link: ENG_3663
Context Link (if applicable):

🔄 Changes

Enumerate the changes made in this pull request, detailing what has been modified, added, or removed. Include technical details and implications if necessary.

Impact:

  • Explain the broader impact of these changes.
  • How it improves performance, fixes bugs, adds functionality, etc.

🖼 Screenshot / 📹 Video

Need a wallet containing an ordinal with satributes, currently not able to

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@terencehh terencehh self-assigned this Feb 6, 2024
Copy link

github-actions bot commented Feb 6, 2024

@terencehh terencehh marked this pull request as ready for review February 6, 2024 07:26
@teebszet teebszet merged commit b091ac8 into develop Feb 6, 2024
5 checks passed
@teebszet teebszet deleted the terence/eng-3663-correct-copy-satribute-not-sattribute branch February 6, 2024 07:37
victorkirov added a commit that referenced this pull request Feb 7, 2024
* changes (#792)

* Fix in page provider injection

---------

Co-authored-by: Terence Ng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants