Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace deprecated util with core #786

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

m-aboelenein
Copy link
Member

🔘 PR Type

What kind of change does this PR introduce?

  • Code style update (formatting, local variables)

📜 Background

Using the newly exported getAppIconFromWebManifest from core

🖼 Screenshot / 📹 Video

Screenshot 2024-02-02 at 9 14 09 AM

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

Copy link

github-actions bot commented Feb 2, 2024

@teebszet
Copy link
Member

teebszet commented Feb 2, 2024

@DuskaT021 I'll test this one. it's a minor change

@m-aboelenein m-aboelenein merged commit 42171ab into develop Feb 2, 2024
5 checks passed
@m-aboelenein m-aboelenein deleted the chore/use-core-manifest-utils branch February 2, 2024 13:35
This was referenced Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants