Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ledger message signing util #784

Conversation

m-aboelenein
Copy link
Member

@m-aboelenein m-aboelenein commented Jan 30, 2024

🔘 PR Type

What kind of change does this PR introduce?

  • Enhancement

📜 Background

depends on secretkeylabs/xverse-core#364
to be tested with secretkeylabs/sats-connect-example#21

🔄 Changes

Enumerate the changes made in this pull request, detailing what has been modified, added, or removed. Include technical details and implications if necessary.

Impact:

  • Explain the broader impact of these changes.
  • How it improves performance, fixes bugs, adds functionality, etc.

🖼 Screenshot / 📹 Video

Include screenshots or a video demonstrating the changes. This is especially helpful for UI changes.

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@m-aboelenein m-aboelenein self-assigned this Jan 30, 2024
victorkirov
victorkirov previously approved these changes Feb 1, 2024
@DuskaT021 DuskaT021 added the 0.29.1 0.29.1 label Feb 2, 2024
Copy link

github-actions bot commented Feb 2, 2024

@m-aboelenein m-aboelenein merged commit 21732db into develop Feb 2, 2024
5 checks passed
@m-aboelenein m-aboelenein deleted the mahmoud/eng-3676-issue-with-address-for-ledger-message-signing branch February 2, 2024 13:45
This was referenced Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.29.1 0.29.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants