-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-3594] feature: Send Max STX #767
Closed
Closed
Changes from 75 commits
Commits
Show all changes
80 commits
Select commit
Hold shift + click to select a range
d6df19b
Add btc send screen skeleton
victorkirov 4ccd4dd
Implement MAX
victorkirov 76c9f31
extract amount selector to component
victorkirov 63f2bb4
Add max dust filtered callout
victorkirov 2ea224a
Fix minor styling
victorkirov 5207c5d
Add fee display
victorkirov ed664f4
Implement fee selection
victorkirov de83299
Add insufficient funds on fee selector
victorkirov b20e4b6
add insufficient funds message on custom fee selector
victorkirov 002dc58
Add insufficient funds gate
victorkirov b7e4ded
fix some todos
victorkirov 4d1b558
Add min and max fee rate
victorkirov e2b0b1a
fix container styling
victorkirov 5f79616
Merge branch 'develop' into victor/eng-3548-ext-send-btc-integrate-txβ¦
victorkirov f304895
fix styling
victorkirov a14b8d4
Fix fee summary on confirm page
victorkirov 225f1bd
fix some component interactions
victorkirov 23dd157
fix a few minor bugs
victorkirov 75fa52d
fix rbf typing
victorkirov b92ad64
Merge branch 'develop' into victor/eng-3548-ext-send-btc-integrate-txβ¦
victorkirov cf3cc1f
Close window if ledger
victorkirov aecf750
Update src/app/ui-library/input.tsx
victorkirov 38223d4
Update src/app/ui-library/input.tsx
victorkirov 0d0409c
Add address editable field
victorkirov d2925dd
Merge branch 'develop' into victor/eng-3548-ext-send-btc-integrate-txβ¦
victorkirov bbd6829
chore: package-lock exact version
teebszet 5a56cd8
refactor: use classnames for variants in ui-library button
teebszet 24d429f
refactor: use css classnames in ui input
teebszet bc45210
fix: edit and pencil icon row
teebszet 06b4efa
fix: recipient input next should be disabled when error
teebszet 1a36ad9
fix: confirm/cancel translation keys
teebszet c04c058
Update core
victorkirov d9c0d67
Merge branch 'develop' into victor/eng-3548-ext-send-btc-integrate-txβ¦
victorkirov fe42aaf
Remove unneeded toNumbers
victorkirov cde4e39
Move error text to feedback
victorkirov fa243f8
add new for BigNumber
victorkirov 636aa49
Make sats/vByte consistent
victorkirov a750d7b
Fix fee select styling
victorkirov 38a9c9a
Fix input styling
victorkirov e2d094c
Merge branch 'develop' into victor/eng-3548-ext-send-btc-integrate-txβ¦
teebszet b753ca2
switch to new spinner
victorkirov b4e4e59
Factor out InputScreen from RecipientSelector
jordankzf bcb34f0
Update InputScreen to accept ReactNode
jordankzf c8efcaa
Step 1: Select Recipient
jordankzf 1cdaa9f
[WIP] Step 2: Select Amount
jordankzf 7389ff3
stxAmountSelector bug fixes
jordankzf a2a58ef
[WIP] Step 3
jordankzf 8374e59
Forward AND reverse BNS lookup
jordankzf df955c3
Indented feedback
jordankzf 2724c60
send async
jordankzf 47607e9
Step3Confirm adapter
jordankzf 3583bc6
wip send max
jordankzf 305df4c
chore: bump core version
teebszet 45f881d
Merge branch 'develop' into victor/eng-3548-ext-send-btc-integrate-txβ¦
victorkirov bbcb677
fix: rotate faders icon
teebszet d2c60d0
Revert "Fix fee select styling"
teebszet 5e00bbb
fix: minor spacing, styling, and colour fixes
teebszet 3e08755
fix: react key warning fix
teebszet b67d1cc
fees
jordankzf 8282c07
bump core
victorkirov 11395ba
Fix api
victorkirov 3fe3c7d
fees
jordankzf eacc169
apply fee
jordankzf ecc0056
remove feeoverride
jordankzf 341f852
Merge branch 'victor/eng-3548-ext-send-btc-integrate-tx-consolidationβ¦
jordankzf 4929264
Merge branch 'develop' of https://github.com/secretkeylabs/xverse-webβ¦
victorkirov 6702d63
Don't log insufficient funds message
victorkirov 0d6d8b2
Fix insufficient amount on load
victorkirov c14f289
Enable rbf on txns
victorkirov 3e8353a
Merge branch 'victor/eng-3548-ext-send-btc-integrate-tx-consolidationβ¦
jordankzf cf11c64
Remove comments
jordankzf b79f6b5
avoid calling setState twice
jordankzf 88d39b5
Merge branch 'develop' of https://github.com/secretkeylabs/xverse-webβ¦
jordankzf 441bf77
Rename btcRecipientSelector
jordankzf 7425a8c
Address Vic feedback
jordankzf 1b30168
address PR comments
abdulhaseeb4239 77346dd
fix: change variant name according to zeroheight
abdulhaseeb4239 d24473c
fix: use the correct variant for memo
abdulhaseeb4239 51ec511
feat: apply stx fee cap logic
abdulhaseeb4239 2b6e22f
fix: setting recipient address
abdulhaseeb4239 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
import React from 'react'; | ||
import styled from 'styled-components'; | ||
|
||
const Container = styled.div` | ||
flex: 1 1 100%; | ||
display: flex; | ||
flex-direction: column; | ||
justify-content: space-between; | ||
`; | ||
|
||
const ButtonsContainer = styled.div` | ||
margin: ${(props) => props.theme.spacing(12)}px 0; | ||
`; | ||
|
||
const InputsContainer = styled.div` | ||
display: flex; | ||
flex-direction: column; | ||
`; | ||
|
||
type InputScreenProps = { | ||
inputs: React.ReactNode; | ||
buttons: React.ReactNode; | ||
header?: React.ReactNode; | ||
}; | ||
|
||
function InputScreen({ inputs, buttons, header }: InputScreenProps) { | ||
return ( | ||
<Container> | ||
<div> | ||
{header} | ||
<InputsContainer>{inputs}</InputsContainer> | ||
</div> | ||
<ButtonsContainer>{buttons}</ButtonsContainer> | ||
</Container> | ||
); | ||
} | ||
|
||
export default InputScreen; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% convinced this component is needed. It's currently used in 1 place with a single input and single button. Do we foresee it being used elsewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kinda agree with @victorkirov here. I get the intent is to abstract away some of the layout logic to make it consistent, but IMO a better abstraction is to store well-defined styled components into ui-library/common.styled.ts.
because in this case, i'm not sure if this InputScreen will work for stx with the memo input.