Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-3548] fix: wrong variable used in validation to show top divider for first asset item in receive in payment section component #762

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

fedeerbes
Copy link
Contributor

🔘 PR Type

  • Bugfix

📜 Background

This PR fixes a wrong variable used in validation to show top divider for first asset item in receive in payment section component

Issue Link: #ENG-3584

Impact:

  • PSBT and batch PSBT screens, receive section of the screen. This can be tested in a PSBT tx where user receives an asset in its payment address, maybe as a change

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

…asset item in receive in payment section component
@fedeerbes fedeerbes self-assigned this Jan 16, 2024
Copy link
Contributor

@dhriaznov dhriaznov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@teebszet teebszet removed their request for review January 17, 2024 12:31
@DuskaT021
Copy link
Contributor

tested can be merged

@DuskaT021 DuskaT021 merged commit dbb2266 into develop Jan 22, 2024
5 checks passed
@teebszet teebszet changed the title fix: wrong variable used in validation to show top divider for first asset item in receive in payment section component [ENG-3548] fix: wrong variable used in validation to show top divider for first asset item in receive in payment section component Jan 23, 2024
@fedeerbes fedeerbes deleted the fix/ENG-3584 branch October 4, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants