Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revisit dns_resolver::impl::do_sendv() as c-ares now handles EWOULDBLOCK for UDP #2489

Open
tchaikov opened this issue Oct 11, 2024 · 0 comments

Comments

@tchaikov
Copy link
Contributor

quote from #2472 (comment)

Finally, I should mention this note is no longer valid in your source code:
seastar/src/net/dns.cc
Line 1017 in bddc7b2
// 1.) c-ares does not handle EWOULDBLOCK for

we always pretend that we are able to send the whole payload even when the promise of the write promise is not available immediately. seems this approach simplifies the implementation. but either way, according to Brad, the comment does not apply anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant