Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make schemaDescriber solely owner of tablets metadata #356

Merged
merged 8 commits into from
Nov 29, 2024

Conversation

sylwiaszunejko
Copy link
Collaborator

Previously tablets metadata was owned by schemaDescriber, HostSelectionPolicy and ring.
This PR makes schemaDescriber solely owner of the data, and rest of the code uses it.
Additionally it changes how the keyspace metadata is stored to copy-on-write map.

Fixes: #353

tablets.go Show resolved Hide resolved
tablets.go Outdated Show resolved Hide resolved
tablets.go Outdated Show resolved Hide resolved
schema_queries_test.go Outdated Show resolved Hide resolved
metadata_scylla.go Outdated Show resolved Hide resolved
@sylwiaszunejko
Copy link
Collaborator Author

@dkropachev could you take a look?

dkropachev
dkropachev previously approved these changes Nov 29, 2024
Copy link
Collaborator

@dkropachev dkropachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change please.

metadata_scylla.go Outdated Show resolved Hide resolved
@dkropachev dkropachev merged commit 3e0a01a into scylladb:master Nov 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make schemaDescriber solely owner of tablets metadata
2 participants