-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Dialog): new component #3684
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabienhebert
requested review from
PetmePant,
matthprost,
lisalupi and
mhervouet
April 17, 2024 16:24
🦋 Changeset detectedLatest commit: 2052f43 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
fabienhebert
force-pushed
the
feat/dialog
branch
from
April 17, 2024 16:28
a5ee9c6
to
d144005
Compare
lisalupi
reviewed
Apr 18, 2024
lisalupi
approved these changes
Apr 18, 2024
BABAK0T0
reviewed
Apr 22, 2024
packages/ui/src/components/Dialog/__stories__/Specification.stories.tsx
Outdated
Show resolved
Hide resolved
BABAK0T0
approved these changes
Apr 22, 2024
fabienhebert
force-pushed
the
feat/dialog
branch
4 times, most recently
from
April 24, 2024 14:36
4e9c52e
to
de8778a
Compare
mhervouet
approved these changes
Apr 24, 2024
fabienhebert
force-pushed
the
feat/dialog
branch
from
April 24, 2024 15:54
de8778a
to
1d84749
Compare
fabienhebert
force-pushed
the
feat/dialog
branch
from
April 24, 2024 16:19
1d84749
to
2052f43
Compare
matthprost
approved these changes
Apr 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type
Summarise concisely:
New component :
Dialog
following this specifications:https://ultraviolet.scaleway.com/6dd9b5c45/p/1169bd-dialog/b/221400