Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(container): add support for healthCheck #249

Merged
merged 7 commits into from
Nov 29, 2024
Merged

Conversation

cyclimse
Copy link
Contributor

Summary

What's changed?

  • Added healthCheck configuration for Serverless Containers
  • Fixed a circular dependency warning introduced in release v0.4.13
  • Changed the handling of std_errors to include a basic reformat for InvalidArguments errors
  • Updated basic example to include health check

Why do we need this?

  • For the InvalidArguments change, this is useful as otherwise you can't see where you got it wrong:

Before:

image

After the change:

image

(Ideally, we should migrate to the SDK is handled std_errors correctly)

  • Align Serverless FW with the newer API features

How have you tested it?

  • Tested locally ✅
    • Deploy the example ✅
    • Removed httpPath, rerun serverless deploy and check that the health check was updated to a tcp probe ✅

Checklist

  • I have reviewed this myself
  • There is a unit test covering every change in this PR
  • I have updated the relevant documentation

Details

README.md Show resolved Hide resolved
@cyclimse cyclimse self-assigned this Nov 28, 2024
@cyclimse cyclimse merged commit 78a8689 into master Nov 29, 2024
15 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants