Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create more informative configuration documentation. #136

Open
djandrewd opened this issue Aug 28, 2017 · 2 comments
Open

Create more informative configuration documentation. #136

djandrewd opened this issue Aug 28, 2017 · 2 comments

Comments

@djandrewd
Copy link

  1. ClusterConfig contains configuration without javadoc and therefore without source code it is impossible to get meaning of most of configuration.
  2. Add TimeUnit to all duration entries. It is hard to understand that they are in ms.
  3. Add configurable constant gossip period.
@antonkharenko
Copy link
Member

@djandrewd Hi, thanks for valuable feedback. I will definitely do it, but I am curious if you can share a bit on a need and use case for the configurable gossip period? And just to clarify there is a property gossipInterval which defines a time between sending gossips and it is configurable, but also there is a computable property ClusterMath.gossipPeriodsToSpread(...) and I assume that you are speaking about the second one.

@djandrewd
Copy link
Author

Yes, I was talking about ClusterMath.gossipPeriodsToSpread.
I need to spread gossip for each of the node only once for example.

aharonha referenced this issue in scalecube/scalecube-services Jul 26, 2018
Prepare new release [skip ci] prepare release v2.1.4
ronenhamias referenced this issue in scalecube/scalecube-services Aug 19, 2018
ronenhamias referenced this issue in scalecube/scalecube-services Aug 19, 2018
Prepare new release [skip ci] prepare release v2.1.4
ronenhamias referenced this issue in scalecube/scalecube-services Aug 19, 2018
Prepare new release [skip ci] prepare for next development iteration
@ronenhamias ronenhamias transferred this issue from scalecube/scalecube-services Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants