You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I could be mistaken in my opinion, but for version updates, I think this grep function is too aggressive/eager, and could use extra arguments to search only in defined paths, i.e. the resulting git grep command could be something like: git grep -I --fixed-strings --files-with-matches 'version' -- 'project' '*.sbt'
I suggest that the extra path arguments be exposed in a new configuration key called something like updates.whitelistGlob. I'm sure there's a better way to call it, though.
I'm not familiar enough with the codebase but I'd be happy to create a PR if this feature is agreeable.
The text was updated successfully, but these errors were encountered:
We recently got a dependency update PR which contains incorrectly updated files that had, by chance, matching versions with the dependency.
In my investigation, I suppose that this mistake comes from this place in the code:
scala-steward/modules/core/src/main/scala/org/scalasteward/core/edit/update/ScannerAlg.scala
Lines 36 to 44 in 667eeda
Coupled with the fact that we are using an unrestrained
git grep
to find the version matches:scala-steward/modules/core/src/main/scala/org/scalasteward/core/git/FileGitAlg.scala
Lines 93 to 96 in 667eeda
I could be mistaken in my opinion, but for version updates, I think this grep function is too aggressive/eager, and could use extra arguments to search only in defined paths, i.e. the resulting git grep command could be something like:
git grep -I --fixed-strings --files-with-matches 'version' -- 'project' '*.sbt'
I suggest that the extra path arguments be exposed in a new configuration key called something like
updates.whitelistGlob
. I'm sure there's a better way to call it, though.I'm not familiar enough with the codebase but I'd be happy to create a PR if this feature is agreeable.
The text was updated successfully, but these errors were encountered: