[1.x] Surface clear cache method for sbt#7868 #1487
Merged
+15
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Friendseeker
force-pushed
the
surface-cache-clean
branch
from
6f1dae5
to
e9f2bc2
Compare
|
LGTM, but I'll leave this around to see if anyone else wants to chime in. |
Looks like other people are not having concern about the PR judging by a lack of comments in the last 24 days. Probably good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c.c. sbt/sbt#7432 (comment)
This PR adds the necessary method in Zinc side to wipe in memory previous compilation.
The next step is for sbt side to invoke the new method (probably as a part of
sbt clean?)