Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional automerge action for scala-steward PRs #39

Closed
joroKr21 opened this issue Nov 25, 2020 · 10 comments
Closed

Optional automerge action for scala-steward PRs #39

joroKr21 opened this issue Nov 25, 2020 · 10 comments

Comments

@joroKr21
Copy link
Contributor

Would there be interest in adding an optional automerge action for scala-steward?

@djspiewak
Copy link
Collaborator

It's definitely doable, I'm just not sure it belongs here. Doesn't mergify meet the criteria? I haven't actually played with it too much.

@joroKr21
Copy link
Contributor Author

I'm not sure either. But it's definitely something that a lot of Scala libraries could benefit from and save some precious maintainer time. Depends on the goals of this plugin.

@joroKr21
Copy link
Contributor Author

@djspiewak how do you regenerate the test files?

@nafg
Copy link

nafg commented Nov 29, 2020

One issue I see with mergify is that apparently you have to specify every matrix permutation like this:

https://github.com/http4s/http4s/blob/main/.mergify.yml

Since the job name includes the minor scala version, this means the mergify file will get invalidated quite often.

Is there a way to make the job names less specific?

@joroKr21
Copy link
Contributor Author

I opened a PR with https://github.com/marketplace/actions/merge-me which is a GitHub action unlike Mergify

@djspiewak
Copy link
Collaborator

Is it possible to use wildcards in the matrix definition? I see some above in the labels.

@joroKr21
Copy link
Contributor Author

joroKr21 commented Mar 2, 2022

This is happening in typelevel/sbt-typelevel#190

@joroKr21 joroKr21 closed this as completed Mar 2, 2022
@nafg
Copy link

nafg commented Mar 2, 2022

You could have just used sbt-mergify-github-actions from https://github.com/nafg/mergify-yaml/. I mentioned it above

@joroKr21
Copy link
Contributor Author

joroKr21 commented Mar 2, 2022

I think sbt-typelevel solves the issue you mentioned about the matrix

@nafg
Copy link

nafg commented Mar 2, 2022

As does my library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants