Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SizeParser to correctly parse and validate windows.PageFileFix fields #148

Open
mdedetrich opened this issue Mar 14, 2023 · 0 comments
Open

Use SizeParser to correctly parse and validate windows.PageFileFix fields #148

mdedetrich opened this issue Mar 14, 2023 · 0 comments

Comments

@mdedetrich
Copy link
Contributor

In #146 we implemented windows.PageFileFix using bare String's which means its possible to put in incorrect values. Ideally we should use https://github.com/sbt/sbt/blob/973cd63e0b6bfe0d06d364f314f391a08a77d38b/internal/util-complete/src/main/scala/sbt/internal/util/complete/SizeParser.scala however its (largely) blocked by #147 (its possible to work around this but its not nice).
@mdedetrich mdedetrich mentioned this issue Mar 14, 2023
Merged
@mdedetrich mdedetrich changed the title Use SizeParser to correctly parse windows.PageFileFix Use SizeParser to correctly parse and validate windows.PageFileFix fields Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdedetrich