From e78c88375fc040658451cd4a9fe512965d94711b Mon Sep 17 00:00:00 2001
From: "Frank T. Bergmann" <frank.thomas.bergmann@gmail.com>
Date: Tue, 27 Aug 2024 18:50:31 +0200
Subject: [PATCH]  - dont crash on unsupported math

---
 src/sbml/conversion/SBMLRateRuleConverter.cpp |  3 ++
 .../test/TestSBMLRateRuleConverter.cpp        | 51 +++++++++++++++++++
 2 files changed, 54 insertions(+)

diff --git a/src/sbml/conversion/SBMLRateRuleConverter.cpp b/src/sbml/conversion/SBMLRateRuleConverter.cpp
index b81b6fd783..b3b313717c 100644
--- a/src/sbml/conversion/SBMLRateRuleConverter.cpp
+++ b/src/sbml/conversion/SBMLRateRuleConverter.cpp
@@ -525,6 +525,9 @@ SBMLRateRuleConverter::isPositive(const ASTNode* node, bool& posDeriv)
 {
   bool signDetermined = false;
 
+  if (!node)
+    return signDetermined;
+
   // node will be refactored so should be able to detect sign from first child
   ASTNodeType_t type = node->getType();
 
diff --git a/src/sbml/conversion/test/TestSBMLRateRuleConverter.cpp b/src/sbml/conversion/test/TestSBMLRateRuleConverter.cpp
index f7c6d5bcf9..7e0a33006e 100644
--- a/src/sbml/conversion/test/TestSBMLRateRuleConverter.cpp
+++ b/src/sbml/conversion/test/TestSBMLRateRuleConverter.cpp
@@ -217,6 +217,56 @@ START_TEST(test_conversion_raterule_converter)
 }
 END_TEST
 
+
+START_TEST(test_crash_converter)
+{
+  ConversionProperties props;
+  props.addOption("inferReactions", true);
+
+  SBMLConverter* converter = new SBMLRateRuleConverter();
+  converter->setProperties(&props);
+
+  SBMLDocument* doc = new SBMLDocument(3, 2);
+  Model* model = doc->createModel();
+  model->setId("m");
+
+  Parameter* parameter1 = model->createParameter();
+  parameter1->setId("s");
+  parameter1->setConstant(false);
+  parameter1->setValue(0);
+
+  Parameter* parameter = model->createParameter();
+  parameter->setId("p");
+  parameter->setConstant(false);
+  parameter->setValue(0);
+
+  parameter = model->createParameter();
+  parameter->setId("k");
+  parameter->setConstant(true);
+  parameter->setValue(0);
+
+  RateRule* rr1 = model->createRateRule();
+  rr1->setVariable("s");
+  ASTNode *math = SBML_parseL3Formula("cos(s)");
+  rr1->setMath(math);
+  delete math;
+
+  RateRule* rr2 = model->createRateRule();
+  rr1->setVariable("s");
+  math = SBML_parseL3Formula("sin(s)");
+  rr1->setMath(math);
+  delete math;
+
+  converter->setDocument(doc);
+  fail_unless(converter->convert() == LIBSBML_OPERATION_FAILED);
+
+  delete converter;
+  delete doc;
+}
+END_TEST
+
+
+
 START_TEST(test_conversion_raterule_converter_non_standard_stoichiometry)
 {
 	// example 3.13 in Fages et al, TCS, 2015
@@ -681,6 +731,7 @@ create_suite_TestSBMLRateRuleConverter (void)
   tcase_add_test(tcase, test_conversion_raterule_converter);
   tcase_add_test(tcase, test_conversion_raterule_converter_non_standard_stoichiometry);
   tcase_add_test(tcase, test_conversion_raterule_converter_hidden_variable);
+  tcase_add_test(tcase, test_crash_converter);
   tcase_add_test(tcase, test_model);
   tcase_add_test(tcase, test_model1);
   tcase_add_test(tcase, test_model2);