Problems pyright raises are dependent on Python version #1102
Comments
Matthijspals
pushed a commit
that referenced
this issue
Mar 22, 2024
This was referenced Mar 22, 2024
janfb
added a commit
that referenced
this issue
Apr 29, 2024
* start testing options of plotting function * Move definition of offdiag_func to get_offdiag_func * opts to kwargs, offdiag plotting func * refactor marginal plots * reformat grid arranger * reformat pairplot * 2d plots working * backwards compatibility * points are back * subplots also working again * first draft of the tutorial * update notebooks before merge * plotting tutorial v0 * transposed col and rows fix * eps xlim fig_kwarg * precommit * fix too long lines * reformat with ruff * allow overwrite bin heuristic with specified bins * remove list brackets * reformat wit ruff * fix pyright * ignore pyright errors, fix proposed in #1102 * Checking return types * Warning-free testing of pairplot * Added typing (incl return types) * reformat with rufus.. * start fixing pyright errors appearing with python 3.8 * (Hopefully) fixed all pyright errors * fix ruff error * Update sbi/analysis/plot.py Co-authored-by: Jan <[email protected]> * Update sbi/analysis/plot.py Co-authored-by: Jan <[email protected]> * Update sbi/analysis/plot.py Co-authored-by: Jan <[email protected]> * Update sbi/analysis/plot.py Co-authored-by: Jan <[email protected]> * Update sbi/analysis/plot.py Co-authored-by: Jan <[email protected]> * Update sbi/analysis/plot.py Co-authored-by: Jan <[email protected]> * update according to Jan's comments, add kde2d func * fix long line endings * add note unused args, update tutorial legends --------- Co-authored-by: Matthijs <[email protected]> Co-authored-by: Fabio Muratore <[email protected]> Co-authored-by: Jan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Different python versions have different (typing) conventions which will raise pyright issues depending on the Python version people have installed. Our suggestion would be to test against old Python versions but do not run pyright and pick one Python version everyone should use to develop to have consistent Pyright errors.
Once we pyright only against a newer Python version we can partly revert 899c063 as newer versions of matplotlib fix it
The text was updated successfully, but these errors were encountered: