Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemctl restart and systemctl stop seems to hang on ubuntu 24.04 if websockets are in use #960

Open
rmah opened this issue Nov 17, 2024 · 1 comment
Milestone

Comments

@rmah
Copy link

rmah commented Nov 17, 2024

Expected Behavior

Executing sudo systemctl restart forwarder should stop the deamon and disconnect any clients immediately and restart even if websocket connections are active.

Actual Behavior

Executing it will hang as long as all websocket clients are active. We get the same behavior with or sudo systemctl stop forwarder.
After all websocket clients are closed, forwarder restarts/stops.

Note: the vast majority of sites using websockets have auto-reconnect handlers in place because websocket streams are so unreliable.

Steps to Reproduce the Problem

  1. Run forwarder on a proxy server
  2. Setup proxy in web browser to use the proxy server
  3. Connect to a website using websockets
  4. Try to execute sudo systemctl restart forwarder (or sudo systemctl stop forwarder) on the proxy server
  5. Watch nothing happen :-)

Specifications

  • Version: v1.3.2
  • Platform: Ubuntu 24.04
  • Subsystem:
@mmatczuk
Copy link
Contributor

It tries to drain the connections, we'll look into this.

@mmatczuk mmatczuk added this to the v1.4 milestone Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants