Several minor samples/ fixes #1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code confusingly never instantiated out_samhdr, and doesn't really have a header to supply. It got away with this because writing FASTA/Q doesn't actually need a header, so make that explicit. Cast time_t, which isn't necessarily a long itself. Use the usual incantation so that doing "make clean" twice completes without diagnostics even when the $(PRGS) files already don't exist.
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The samples/write_fast.c code confusingly never instantiated
out_samhdr, and doesn't really have a header to supply. It got away with this because writing FASTA/Q doesn't actually need a header, so this PR makes that explicit.Cast
time_t, which isn't necessarily alongitself.Use the usual
-rm -fincantation so that doingmake cleantwice completes without diagnostics even when the$(PRGS)files already don't exist.