Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SSR] Make dynamic import()s no-ops #4875

Open
nolanlawson opened this issue Nov 15, 2024 · 3 comments
Open

[SSR] Make dynamic import()s no-ops #4875

nolanlawson opened this issue Nov 15, 2024 · 3 comments

Comments

@nolanlawson
Copy link
Collaborator

nolanlawson commented Nov 15, 2024

In the SSR compiler, dynamic import()s should (probably) be no-ops because we run in sync mode so you wouldn't be able to do anything with the constructor you import anyway.

We also need to strip these import()s anyway because core will complain if it sees them after compilation.

@nolanlawson nolanlawson changed the title [SSR] Make dynamic import()s no-ops and block importing @lwc/ssr-runtime [SSR] Make dynamic import()s no-ops Nov 15, 2024
Copy link

git2gus bot commented Nov 15, 2024

This issue has been linked to a new work item: W-17248485

@wjhsf
Copy link
Contributor

wjhsf commented Nov 18, 2024

If we're moving forward with sync mode, do we need to block more flavors of async operations?

@nolanlawson
Copy link
Collaborator Author

No, they just won't work. We already have a test for Promise.resolve().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants