-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SSR fixtures to emit individually transformed files #4835
Comments
We already have |
There's no way as far as I know to make rollup keep unused imports. Perhaps this should be done without rollup? |
Yeah the idea is:
There is a case to be made that this isn't worth it – we may end up writing a lot of extra test code just for a bit of extra debuggability. |
We can't test that #4840 works without some way of generating non-bundled files. |
I don't understand. Don't we have tests here to confirm that there are no unused import warnings? lwc/packages/@lwc/ssr-compiler/src/__tests__/fixtures.spec.ts Lines 60 to 69 in 2d11a5b
|
Oh yeah, once we fix all unused imports, then we can delete line 64 and it'll be implicitly tested. We just got nothing for now. |
Currently, the SSR fixtures emit a single file,
compiled-experimental-ssr.js
, which is generated by rollup. This can hide some issues, such as unused imports, that would be more easily identified if the fixtures were generated as individual files prior to bundling into a single file.This will require a bit of additional logic to fully walk the import graph to identify all files that may need to be transformed.
The text was updated successfully, but these errors were encountered: