Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SSR v2] add support for computed keys in wire config #4827

Open
divmain opened this issue Nov 11, 2024 · 1 comment
Open

[SSR v2] add support for computed keys in wire config #4827

divmain opened this issue Nov 11, 2024 · 1 comment

Comments

@divmain
Copy link
Contributor

divmain commented Nov 11, 2024

See this thread. After #4807 is merged, the SSR compiler will have almost full support for wire adapters. However, this PR does not include support for computed keys in wire config. Instead, if non-identifiers are found for keys, an error is thrown during compilation.

Here is an example of that:

 @wire(getBar, { 
   ['computedStringLiteral']: '$prop', 
   [123n]: '$prop', 
   [321]: '$prop', 
   [null]: '$prop', 
   [undefined]: '$prop' 
 })

This issue should be considered fixed when an error "@wire config entry key must be an identifer" is no longer thrown during compilation of the above wire decorator, and the correct behavior from engine-* is reproduced in the SSR compiler.

Copy link

git2gus bot commented Nov 11, 2024

This issue has been linked to a new work item: W-17206172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants