Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SSR v2] Consolidate mechanisms that validate identifier/field names #4826

Open
divmain opened this issue Nov 11, 2024 · 3 comments
Open

[SSR v2] Consolidate mechanisms that validate identifier/field names #4826

divmain opened this issue Nov 11, 2024 · 3 comments
Labels
BUG P3 enhancement SSR

Comments

@divmain
Copy link
Contributor

divmain commented Nov 11, 2024

The new SSR compiler includes an isValidIdentifier helper function, which determines whether a given string is a valid JavaScript identifier. However, there exists something similar in babel-plugin-component. These should probably be consolidated onto the babel-plugin-component implementation for backwards compatibility reasons.
@divmain divmain added the SSR label Nov 11, 2024
@divmain divmain mentioned this issue Nov 11, 2024
Merged
@git2gus Git2Gus
Copy link

git2gus bot commented Nov 11, 2024

This issue has been linked to a new work item: W-17206167

@nolanlawson
Copy link
Collaborator

Details here

@cardoso
Copy link
Contributor

cardoso commented Nov 18, 2024

Should this go in @lwc/shared?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BUG P3 enhancement SSR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nolanlawson @divmain @cardoso