-
-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/display authors names from git repo #290
base: main
Are you sure you want to change the base?
Feature/display authors names from git repo #290
Conversation
This is very cool, are you planning to continue? @ammardev |
Yes, Of course. I'm busy right now, But I would like to continue as soon as possible. |
Hi @ammardev , I hope you're doing well. |
Hi @saleem-hadad , I'm OK thanks. I didn't have much time to contribute to open-source projects in the previous few months. But I'm planning to continue soon. |
Hello, @saleem-hadad Sorry for being late. My updates are finished for the backend side. I was planning to write some tests. But then I realized that I can't actually mock git operations (Commits). Do you have any idea for testing? |
Yes, you can have an interface for GitService and then mock the interface in testing, similar to this logic |
Hello there,
This is a draft PR for getting information about each individual page author.
Data about authors are fetched from the GIT repository.
It's an improved version of "Added/updated by - from git" in Future Development issue #6.
These are some examples of the final result:
A page with one contributor:
A page with many contributors:
The design is inspired by vs code feature:
This update needs some refactoring and work. But I wanted to get feedback from the repo owner and the community before implementing the whole feature. So, please feel free to comment if you have any ideas or improvements for this feature.
The remaining tasks to complete this draft:
Check if the file is committed in a repository.(Ignore if not committed)