[bug]: filter not working

[Hassanabdelqader]

Describe the bug

filter not working when you are in page 2 or 3 or any page instead of 1

How to reproduce

run the project
go to page 2 or page 3 or any page
then select status and choose any of the option
the page return back to page 1 but the data is not filtered based on status

Link to reproduction

https://github.com/sadmann7/shadcn-table

Additional information

No response

[Hassanabdelqader]

Follow up

[sadmann7]

should be fixed now

[Hassanabdelqader]

@sadmann7 no still not fixed

[noxify]

Hi @Hassanabdelqader ,

tested it quickly and it seems to work:

Bildschirmaufnahme.2024-10-23.um.23.13.28.mov

And here the recording with the advanced filter:

Bildschirmaufnahme.2024-10-23.um.23.15.17.mov

---

@sadmann7 - it seems that the status count inside the filter is not counting correctly.
We have 13 records with the status Todo, but the count ( inside the badge ) shows 10.

[Hassanabdelqader]

Hi please try this scenario
Choose status more than one
Then go to page 2 or 3
Then click reset

[Hassanabdelqader]

Also try this scenario
Click update and make an error the sheet update close it should stay open and only close when update successed

[sadmann7]

Hi @Hassanabdelqader ,

tested it quickly and it seems to work:

Bildschirmaufnahme.2024-10-23.um.23.13.28.mov
And here the recording with the advanced filter:

Bildschirmaufnahme.2024-10-23.um.23.15.17.mov
@sadmann7 - it seems that the status count inside the filter is not counting correctly. We have 13 records with the status Todo, but the count ( inside the badge ) shows 10.

was a caching issue, should be fixed now

[Hassanabdelqader]

Can you just tell me what exactly have you changed since i applied the table with another project and i need just the changed

[sadmann7]

Describe the bug

filter not working when you are in page 2 or 3 or any page instead of 1

How to reproduce

run the project go to page 2 or page 3 or any page then select status and choose any of the option the page return back to page 1 but the data is not filtered based on status

Link to reproduction

https://github.com/sadmann7/shadcn-table

Additional information

No response

as soon as you will choose a filter on a different page, it will send you to page 1

thats the best practice for server side filtering imo

data is always being filtered unless you click reset, as @noxify showed

[sadmann7]

Can you just tell me what exactly have you changed since i applied the table with another project and i need just the changed

try using this hook

use-data-table