Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reversing and permuting axes do not require consuming an array #1443

Open
akern40 opened this issue Oct 20, 2024 · 0 comments
Open

Reversing and permuting axes do not require consuming an array #1443

akern40 opened this issue Oct 20, 2024 · 0 comments

Comments

@akern40
Copy link
Collaborator

akern40 commented Oct 20, 2024

Currently, reversed_axes and permuted_axes take mut self and self, respectively. However, neither of them "consume" the array, since they are just modifying the shape and strides. Can these be changed to alter the arrays in-place? For a transition, perhaps we could provide reverse_axes and permute_axes as inplace variants, and either keep or deprecate these two methods?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant