Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set rust-version to 1.76 & add matrix for building and testing for MSRV #167

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

elpiel
Copy link
Contributor

@elpiel elpiel commented Nov 22, 2024

closes #166

@thejpster
Copy link
Member

exclusive range pattern syntax is experimental

oops. Should be easily fixable.

@elpiel
Copy link
Contributor Author

elpiel commented Nov 23, 2024

Yeah, they are easy to fix.
Will get to that.

@elpiel
Copy link
Contributor Author

elpiel commented Nov 24, 2024

I fixed the pattern matching but this trim_ascii_end is giving me a headache.
Any ideas how to replace it?

@thejpster
Copy link
Member

thejpster commented Nov 25, 2024

You could just copy/paste the source code from the newer library:

impl VolumeName {
    pub fn name(&self) -> &[u8] {
        let mut bytes = &self.contents[..];
        while let [rest @ .., last] = bytes {
            if last.is_ascii_whitespace() {
                bytes = rest;
            } else {
                break;
            }
        }
        bytes
    }
}

@elpiel
Copy link
Contributor Author

elpiel commented Nov 26, 2024

Yep, that should do the trick.
I think I initially just used &self.content which didn't work.

Checks are passing now 🎉

@thejpster
Copy link
Member

Yeah because Volume Names are padded with space characters.

@thejpster
Copy link
Member

The build tasks have been renamed so CI is sad because the job it wants to see didn't run.

The configuration for which jobs are mandatory should be in git, but it's not. It's hidden in GitHub's proprietary back-end.

@thejpster thejpster merged commit 376035a into rust-embedded-community:develop Nov 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider an appropriate MSRV
2 participants