Allow for plans to be partially successful #4709
Conversation
When automerge is true, if any plan fails, all plans get deleted This is true even when running from a github comment. When dealing with many projects, there is a high likelihood that one plan can fail. This allows us to keep apply some plans and reiterate so we don't lose all progress.
shkamensky
requested review from
chenrui333,
lukemassa and
nitrocode
and removed request for
a team
|
hi @shkamensky this will require some reviews that will take some time , in the meantime please add docs and tests. Thanks |
GenPage
added
feature
|
This issue is stale because it has been open for 1 month with no activity. Remove stale label or comment or this will be closed in 1 month. |
|
It would be a shame if this PR would go to waste because of staleness. |
|
This issue is stale because it has been open for 1 month with no activity. Remove stale label or comment or this will be closed in 1 month. |
|
@shkamensky are you willing to add the things that @jamengual is asking for? This PR would be a life saver! |
|
@LukasdeBoer , I really want to pursue this! This is for work and I need to make time to work on this. Once I get clearance I will continue this PR (and maybe others). Sorry for the delay. We desperately need this as well :-). |
|
This issue is stale because it has been open for 1 month with no activity. Remove stale label or comment or this will be closed in 1 month. |
|
bamp |
|
@LukasdeBoer good news, I will be able to work on this next week or the week after! Are there any conventions for tests/docs, or a nice example PR I can model after? |
|
any PR that was merge from @lukemassa or @GenPage could be a good example |
|
This issue is stale because it has been open for 1 month with no activity. Remove stale label or comment or this will be closed in 1 month. |
When automerge is true, if any plan fails, all plans get deleted
This is true even when running from a github comment. When dealing with many projects, there is a high likelihood that one plan can fail.
This allows us to keep apply some plans and reiterate so we don't lose all progress.
what
Allow for plans to be saved when automerge is true by passing a flag.
why
Because the all-or-nothing nature of saving plans can make it very difficult to apply across many projects. For example, if 1 failed because of a DNS issue and 150 others plans succeeded, we want to apply the plans that succeeded and deal with the 1 plan manually.
tests
references
#3002