Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space is not efficiently used when in overflow menu #239

Closed
Gitoffthelawn opened this issue Jan 24, 2020 · 2 comments
Closed

Space is not efficiently used when in overflow menu #239

Gitoffthelawn opened this issue Jan 24, 2020 · 2 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@Gitoffthelawn
Copy link
Contributor

Bug description

When the toolbar button is placed in Firefox's overflow menu, the space available is not used efficiently.

Although the horizontal width seems to be (currently) restricted by Firefox, there is much whitespace around the QR code. This is true when SVG mode is used

When canvas mode is used, the left and right sides of the QR code are cropped.

May be related to: #208

Steps to reproduce

Add toolbar button to Firefox's overflow menu. Generate QR codes.

Actual behavior

See above.

Expected behavior

Use the space available efficiently to maximize the size of the QR code.

System

Windows, Firefox 72.0.2, QR Code Generator 1.6

@Gitoffthelawn Gitoffthelawn added the bug Something isn't working label Jan 24, 2020
@rugk
Copy link
Owner

rugk commented Jan 24, 2020

Duplicate of #35

@rugk rugk marked this as a duplicate of #208 Jan 24, 2020
@rugk rugk closed this as completed Jan 24, 2020
@rugk rugk added the duplicate This issue or pull request already exists label Jan 24, 2020
@rugk rugk marked this as a duplicate of #35 Jan 24, 2020
@rugk
Copy link
Owner

rugk commented Jan 24, 2020

Yeah that is currently a problem with some settings.
You can at least work around it by adjusting the size in the settings or selecting a different size in the settings.

BTW, next time: A screenshot would have been very useful. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants