Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add submit for approval and update information buttons at the top of the partner's profile view. #4807

Closed
2 tasks
cielf opened this issue Nov 29, 2024 · 0 comments · Fixed by #4808
Closed
2 tasks

Add submit for approval and update information buttons at the top of the partner's profile view. #4807

cielf opened this issue Nov 29, 2024 · 0 comments · Fixed by #4808
Assignees
@danielabar
Labels
Difficulty—Beginner

Comments

@cielf
Copy link
Collaborator

cielf commented Nov 29, 2024

Summary

'Twin' the submit for approval and update information buttons that are currently at the bottom of the partner's profile views to the top.

Why?

Mitigate the issue of partners neglecting to submit for approval. It's a very big form, and unless they scroll down, they might not realize they have to.

Details

To see what we mean:
sign in as [email protected]
My Profile
It has submit for approval and update information buttons at the bottom

Let's have them at the top, too. Same rules for when they appear.

Criteria for Completion

  • the buttons appear at the top as well
  • tests to support that behaviour
danielabar added a commit to danielabar/human-essentials that referenced this issue Nov 30, 2024
@danielabar
[rubyforgood#4807] Help partner to remember to submit profile for app…
2bb4568 
…roval:

* Duplicate partner actions at top and bottom of long view
* Extract action sto partial to avoid code duplication
* Maintain partner system tests
@danielabar danielabar mentioned this issue Nov 30, 2024
Merged
dorner pushed a commit that referenced this issue Nov 30, 2024
@danielabar
[#4807] Help partner to remember to submit profile for approval: (#4808)
f6f64e1 
* Duplicate partner actions at top and bottom of long view
* Extract action sto partial to avoid code duplication
* Maintain partner system tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielabar danielabar

Labels
Difficulty—Beginner
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#4807] Help partner to remember to submit profile for approval: danielabar/human-essentials
2 participants
@danielabar @cielf